F/OS-1224 Multisig approvers not appearing in past proposals

josemarinas commented 5 months ago

Description

Some approvers did not appear as approvers on past proposals after they've been removed from the multisig because the entity for the multisift members and approvers was related.

This fixes this issue using the solution discussed here: https://www.notion.so/aragonorg/Subgraph-Bug-Approvers-Query-Breaks-Multisig-Subgraph-d783e196ba464595974ba2a9d2dac80a#5ca1bd831bbd4dc191dd8fb0d4360e8f

Task ID: OS-1224

Playground: https://subgraph.satsuma-prod.com/aragon/osx-test-members-bug-mainnet/version/5/playground

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have selected the correct base branch.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[x] I ran all tests with success and extended them if necessary.
[ ] I have updated the CHANGELOG.md file in the root folder.
[ ] I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
[ ] I have updated the UPDATE_CHECKLIST file in the root folder.
[x] I have updated the Subgraph and added a QA URL to the description of this PR.

clauBv23 commented 5 months ago

Since there is a branch for removing all plugins, multisig included, f/split-linting, not sure if this should be done only in this repo

josemarinas commented 5 months ago

Since there is a branch for removing all plugins, multisig included, f/split-linting, not sure if this should be done only in this repo

Yes, this should also be done in the split repo, but i wanted to first get the fix reviewed and then aply it also to the other repo

josemarinas commented 5 months ago

@clauBv23 I fixed the lint missues that you mentioned, I also took the librety some others that popped up when I ran yarn lint. I also updated the description in the schema.graphql

aragon / osx