aragon / radspec

🤘 Radspec is a safe interpreter for Ethereum's NatSpec
MIT License
141 stars 36 forks source link

Fix infinity loop issue #127

Closed loga4 closed 2 years ago

loga4 commented 2 years ago

Pay attention, the @notice parameter of the assignVested method in the TokenManagercontract breaks theradspec` parser: there is a infinity loop. There are several options on how to fix this:

  1. Correct the notice in the TokenManager contract;
  2. Add simple protection from infinity loop;
  3. Add a validation check for the AST tree.

Considering that the radspec and Token Manager contract has not been updated for a long time - there is a proposal to go on the first and second point.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

githubdoramon commented 2 years ago

@loga4 can you pls fix the lint issue?

loga4 commented 2 years ago

@loga4 can you pls fix the lint issue?

oh, my bad, sorry) done

codecov[bot] commented 2 years ago

Codecov Report

Merging #127 (040177a) into master (8aef856) will increase coverage by 1.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   92.19%   93.23%   +1.04%     
==========================================
  Files          37       37              
  Lines         756      769      +13     
==========================================
+ Hits          697      717      +20     
+ Misses         59       52       -7     
Impacted Files Coverage Δ
src/parser/index.js 90.09% <100.00%> (+4.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aef856...040177a. Read the comment docs.