search

aragon / radspec

🤘 Radspec is a safe interpreter for Ethereum's NatSpec
MIT License
141 stars 36 forks source link

Vote didn't close properly. #30

Closed rainbowjaw closed 6 years ago

rainbowjaw commented 6 years ago

Was testing the current testnet alpha. Didn't check the version, this was a few days ago.

I set up two accounts. One had more voting tokens (over majority)

I set up a vote with the minority token holder (so vote wouldn't clear automatically) I voted with the second account as a "no"

The vote timer was still running after transaction had cleared and majority was now reached... I was able to send another vote with majority token holder, and changed my vote to "FOR". The timer stopped, and the vote was a successful yes.

Haven't gotten a chance to try to reproduce this. Even if somehow the required majority was off, shouldn't the vote end when it receives 100% votes?

rainbowjaw commented 6 years ago

Sorry i think i put this in the wrong area

luisivan commented 6 years ago

Yes, no problem