aragon / radspec

🤘 Radspec is a safe interpreter for Ethereum's NatSpec
MIT License
141 stars 36 forks source link

Upgrade web3.js for latest node.js (<11) support #76

Closed schmidsi closed 5 years ago

schmidsi commented 5 years ago

The scrypt packages which is a dependency of web3-eth (and others) does not work with node.js >=11.15. This issue is already solved in https://github.com/ethereum/web3.js/pull/2938, so theoretically it should be sufficient to just update web3 to the latest 1.x version (which happens in this pull-request). Unfortunately, after this update, some of the tests fail :(

I did not have time to find the root cause of this, but just wanted to inform about my failing attempt.

Maybe in the meantime, add something like this to package.json?

    "engines": {
        "node": ">=8.0.0 <=11.15.0"
    },

I can confirm that it works with Node.js@10.16.3 (LTS)

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

sohkai commented 5 years ago

Thanks @schmidsi, I'll look into why the tests are failing!

I think with web3.js having a proper v1 we can also remove the pin, since that was a fix for more unpredictable releases of web3.js previously :).

schmidsi commented 5 years ago

I think with web3.js having a proper v1 we can also remove the pin, since that was a fix for more unpredictable releases of web3.js previously :).

As far as I know, web3 v1 is pretty stable: https://medium.com/@samuel_91690/1-0-release-web3-js-ddd23d3c8f62

sohkai commented 5 years ago

Yep, exactly :).

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.01%) to 90.85% when pulling 7b906f851a16e77c51714860947c973b1d273b1e on schmidsi:upgrade-web3 into 1dc05b68c340df45527c62e339005954c09550ad on aragon:master.

sohkai commented 5 years ago

Will release as a release candidate and test with a few existing examples to make sure nothing else was broken :).