Closed schmidsi closed 5 years ago
Thanks @schmidsi, I'll look into why the tests are failing!
I think with web3.js having a proper v1 we can also remove the pin, since that was a fix for more unpredictable releases of web3.js previously :).
I think with web3.js having a proper v1 we can also remove the pin, since that was a fix for more unpredictable releases of web3.js previously :).
As far as I know, web3 v1 is pretty stable: https://medium.com/@samuel_91690/1-0-release-web3-js-ddd23d3c8f62
Yep, exactly :).
Will release as a release candidate and test with a few existing examples to make sure nothing else was broken :).
The scrypt packages which is a dependency of web3-eth (and others) does not work with node.js >=11.15. This issue is already solved in https://github.com/ethereum/web3.js/pull/2938, so theoretically it should be sufficient to just update web3 to the latest 1.x version (which happens in this pull-request). Unfortunately, after this update, some of the tests fail :(
I did not have time to find the root cause of this, but just wanted to inform about my failing attempt.
Maybe in the meantime, add something like this to package.json?
I can confirm that it works with Node.js@10.16.3 (LTS)