Rename icons - Githubissues

bpierre commented 6 years ago

Opening an issue after having discussed this with @izqui.

Our icon set is composed of actions (notifications, wallet, …) and app icons (tokens, fundraising, …). Some icons used for apps are also used to represent actions. At the moment, their name is describing the app they represent.

This is the Identity app icon, which is named IconIdentity:

You can see it being used in the Aragon menu:

And this same icon is also used as a “Transfer token” action in the Tokens app:

Icons names should describe what they represent in the most generic way, rather than the app they happen to represent (in the example above, it could be “user-add”).
If an app is using an icon from the Aragon UI icon set, this app is free to duplicate it.

izqui commented 6 years ago

👍

Regarding app icons, for all aragon-apps we are probably fine having the icons in aragon-ui, but ideally apps would define their icon filename in the manifest.json and then we would load it.

sohkai commented 6 years ago

We'll be able to provide an icon path for aragon-apps' manifest.json since we need to copy over the assets from aragon-ui anyway. Better to dogfood.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

bpierre commented 5 years ago

Closing as icon names are now coming from the design system.

aragon / ui

Rename icons #32