search

aragon / ui

🦚 UI kit for decentralized apps
https://ui.aragon.org/
MIT License
343 stars 127 forks source link

Make `styled-components` a peerDependency? #35

Closed sohkai closed 6 years ago

sohkai commented 7 years ago

A consumer of this package could want to use their own instance (or version) of styled-components. It'd be nice if they could install and provide their own instance of styled-components.

bpierre commented 7 years ago

On one side, I’d like to limit as much as possible the number of dependencies people have to install in order to start an Aragon app.

On the other side, I agree that styled-component is quite an important one, people have to use it at some point, and they might want to have some control over it. Apart from react and react-dom, it would be the only dependency needed. Let’s do it! 🔥

We could limit it to minor versions, as we do with react and react-dom. The risk is that styled-components could break the compatibility without publishing a major version, but it shouldn’t be a problem if we maintain the list of peer deps to a minimum.

sohkai commented 7 years ago

Limiting it to minor versions should be fine; I assume the styled-components guys, of all people, know what the community expects from them in terms of version upgrades.

I’d like to limit as much as possible the number of dependencies people have to install in order to start an Aragon app.

Totally agree! Some of these more "fundamental" libraries we rely on and expect the user to have control over will likely be handled by @aragon/aragon-dev-cli's boilerplates (e.g. react) in the common use case.

status-open-bounty commented 6 years ago

Balance: 0.000000 ETH Tokens: ANT: 10.00 Contract address: 0x0cd91bf5223e0e535c3e7dd1a12d68c2df039ea2 Network: Mainnet Paid to: fiber-god Visit https://openbounty.status.im to learn more.