search

aragon / ui

🦚 UI kit for decentralized apps
https://ui.aragon.org/
MIT License
343 stars 127 forks source link

Feature/dao 370 aragon UI GitHub action error (do not merge to master until everyone reviewed) #843

Closed yuetloo closed 3 years ago

yuetloo commented 3 years ago

Please review the code and understand how merge-release updates npm version. Npm version are triggered by certain commit messages, i.e. "feat:" will trigger minor version bump, "BREAKING CHANGE" will trigger major version bump, all other will trigger patch version change. @Rekard0 - v2 branch will need "BREAKING CHNAGE" in your commit message to trigger major version change...

https://github.com/mikeal/merge-release#workflow

Also, it wont' update package.json (version), only the tag will have the proper version in the package.json file. See here: https://github.com/mikeal/merge-release/issues/12#issuecomment-571252655

I don't think this workflow was ever used to publish npm package as the actions failed for more than 9 months.

linear[bot] commented 3 years ago
DAO-370 Aragon UI github action error

The error was `not in a git directory` [https://github.com/aragon/ui/runs/2746409141?check_suite_focus=true](https://github.com/aragon/ui/runs/2746409141?check_suite_focus=true)

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅