search

arakasi72 / rtinst

seedbox installation script for Ubuntu and Debian systems
MIT License
1.22k stars 259 forks source link

certbot isn't installed by defaut for letsencrypt ssl Debian 10 #439

Closed Seeder101 closed 5 years ago

Seeder101 commented 5 years ago

Hi arakasi! hope you are doing good I've noticed that the rtinst will not install certbot and python-certbot-nginx packages for Debian 10 at least and would left me with a certbot failure and fallback to self-signed cert even tho my domain is full and the script is seeing it just fine DN: hostname.domain.com but it will utterly fail and then I thought maybe I could actually manually do the letsencrypt thing but when I tried to type certbot in the command nothing was showing up lol and then tried apt install certbot python-certbot-nginx and installed ok after that I ran the script for the second time and it worked perfectly so I guess the missing piece is certbot installation and nginx python certbot script for Debian 10 at least

Thank you

arakasi72 commented 5 years ago

There was an error installing certbot specific to Debian 10. I have now fixed this and issued a new release. Anyone that had a problem can update to the new release and run 'sudo rtletsencrypt'

It should now correctly install certbot and generate the certificates.

Thanks for alerting me to the problem,

Seeder101 commented 5 years ago

There was an error installing certbot specific to Debian 10. I have now fixed this and issued a new release. Anyone that had a problem can update to the new release and run 'sudo rtletsencrypt'

It should now correctly install certbot and generate the certificates.

Thanks for alerting me to the problem,

I see. Much appreciate the fix. but is that also will work with the normal rtinst ? or does rtinst actually call for rtletsencrypt to install the cert ?

Thanks

arakasi72 commented 5 years ago

rtinst uses the rtletsencrypt script, so only need to make changes to rtletsencrypt.

It is now fixed whether called by rtinst or run directly.