search

arakoodev / EdgeChains

EdgeChains.js Typescript/Javascript production-friendly Generative AI. Based on Jsonnet. Works anywhere that Webassembly does. Prompts live declaratively & "outside code in config". Kubernetes & edge friendly. Compatible with OpenAI GPT, Gemini, Llama2, Anthropic, Mistral and others
https://www.arakoo.ai/
MIT License
326 stars 66 forks source link

replace org.json.JSONObject vs GSON/Jackson/Moshi #214

Open sandys opened 10 months ago

sandys commented 10 months ago

we use JSONObject in multiple places. If we can reduce amount of code using GSON/Jackson/Moshi - we should do that.

Performance is not the top criteria here.

adi-kmt commented 10 months ago

Some benchmarks you can have a look at. I think Jackson does look better according to the above link. Could work on this, if you want.

sandys commented 10 months ago

@kamathis4 that sounds good! this should be a relatively straight forward...but very impactful project if u do it.

P.S. dont forget to add testcases

sandys commented 10 months ago

@kamathis4 one of the reason we are preferring GSON/Moshi is because of https://github.com/arakoodev/EdgeChains/issues/220

there is a very interesting path there to take!

adi-kmt commented 10 months ago

So you suggest moshi since it's easily interoperable with android?

sandys commented 10 months ago

@kamathis4 would love to hear your thoughts and evaluation!