search

arakoodev / FlySpring

Developer-friendly Spring Boot flavor. Supercharged cli "flyfly" to make you fall in love with Java again
MIT License
7 stars 7 forks source link

#32 Enabled graceful shutdown in application.properties #39

Open vemanavenkatesh137 opened 1 year ago

vemanavenkatesh137 commented 1 year ago

Enabled graceful shutdown in application.properties

Included below properties in application.properties file server.shutdown=graceful spring.lifecycle.timeout-per-shutdown-phase=15s

This PR Fixes #32

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

vemanavenkatesh137 commented 1 year ago

I have read the Arakoo CLA Document and I hereby sign the CLA

vemanavenkatesh137 commented 1 year ago

recheck

sandys commented 1 year ago

Hi Venkatesh Thanks for the commits !

Are u on discord? Would love to say hello to you

On Sun, Mar 5, 2023, 13:38 Venkatesh Vemana @.***> wrote:

Reopened #39 https://github.com/arakoodev/FlySpring/pull/39.

— Reply to this email directly, view it on GitHub https://github.com/arakoodev/FlySpring/pull/39#event-8667512834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASYU24RSWHKIAOG2HNXWDW2RCW3ANCNFSM6AAAAAAVQASUVA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

pizzaboi21 commented 1 year ago

Hi @vemanavenkatesh137, I see that the dependency "spring-boot-starter-security" is missing. This dependency will be required by FlyFly to have a /shutdown endpoint. Can you please add these? Thank you for the commit!