search

arallsopp / hass-hue-icons

Additional vector icons for home assistant to model Philips Hue bulbs and fixtures.
Other
300 stars 25 forks source link

Non Hue icons? HomePod #170

Closed Mariusthvdb closed 2 years ago

Mariusthvdb commented 2 years ago

What is the specific model of hue fixture/bulb that you want an icon for

Not sure if you are open to adding some other devices icons to your repo, so feel free to close if you dont... It would be way cool though if you would ;-)

As per title, Id love an icon for the Apple HomePod device, more particular the mini variant

Provide a URL that points to an image of this fixture/bulb

These are from the Apple support page, but I guess there are even better images on the net

images-2 images

Additional context

Thanks if you would consider!

arallsopp commented 2 years ago

Reminds me... I'm supposed to be creating a custom repo for these things. I won't be adding that one here, but I will flag it for a custom one.

Mariusthvdb commented 2 years ago

please see https://github.com/Mariusthvdb/Custom-icons where I hope to credit you correctly? I have had these custom icons in 4 different resources And the huge Font awesome Pro, and finally found the time to figure things out a bit. Maybe safe yourself the time for the custom repo?

Ofc, there's no HomePod icon in yet...

arallsopp commented 2 years ago

How about I create one and send it across as a first contribution:)

Mariusthvdb commented 2 years ago

wow, I would be honored !! thanks if you would. so appreciated.

arallsopp commented 2 years ago

Its coming...

image image
arallsopp commented 2 years ago

Added icons and created a pull request for you here: https://github.com/Mariusthvdb/Custom-icons/pull/1

Icon Name
apple-homepod
apple-homepod-mini

The images linked above are from that pull request. I've updated the .js file to include both.

Last question: Are you happy for me to send people to your repo if they request icons that aren't hue based?

Mariusthvdb commented 2 years ago

sure, and thanks!

Im not much of an icon creator, but if people have an .svg, we can easily add those, no problem at all! Ive enabled Discussion, to easily keep things organized.

so I added the first couple of .svg's in a table as you suggested. Is a nice and required feature indeed. For many icons, I only have the path available though so can not add a .svg file in the doc folder yet, not show a preview.

Do you know if we can create these online, based on the path?

arallsopp commented 2 years ago

yeah, just open the path and add the svg descriptor to it, then save as whatever.svg.

eg:

path: "M14.2,11.2l0.1,11L9.9,23l-1.8-0.2V11.9l3.7-0.8l0,0l1.7-10L14.1,1l1.8,0.2L14.2,11.2z"

becomes:

<svg viewBox="0 0 24 24" height="24px" width="24px" fill="#44739e" xmlns="http://www.w3.org/2000/svg"><path d="M14.2,11.2l0.1,11L9.9,23l-1.8-0.2V11.9l3.7-0.8l0,0l1.7-10L14.1,1l1.8,0.2L14.2,11.2z"/></svg>

Mariusthvdb commented 2 years ago

yes, but in which editor is that? a mere text editor?

arallsopp commented 2 years ago

Yep. Simpler the better. Don’t use word. BBEdit or Notepad will be fine.

arallsopp commented 2 years ago

Actually, @Mariusthvdb, just realised you can do it directly within github.

If you already have the file and just want to add a fill colour, you can edit the svg file by finding it in the code view, then clicking the little pencil to edit it.