search

aram535 / movie-renamer

0 stars 1 forks source link

Plurals are capitalised #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run a file called 'A Knights Tale'
2.
3.

What scrapper are you using ? (only version >= 2.0)
'SCRAPER' (one 'P') is imdb.com

What is the expected output? What do you see instead?
Expected: A Knight's Tale (2001) (Heath Ledger).avi
Result: A Knight'S Tale (2001) (Rufus Sewell).avi

What version of Movie Renamer are you using? On what operating system?
1.3.6 Alpha on Windows Server 2003 32bit

Please provide any additional information below.
It appears that any plurals that use an apostrophe will be capitalised when 
they shouldn't be.
http://www.imdb.com/title/tt0183790/

Original issue reported on code.google.com by sran...@gmail.com on 18 Dec 2012 at 11:54

GoogleCodeExporter commented 9 years ago 
In French ' is used to separate word from preposition, and we prefer to have a 
uppercase after this.

Example :
  L'Empire contre attaque

But yes, in English, it should be "Knight's" instead of "Knight'S".
I will fix this ;-)

Original comment by nico.ma...@gmail.com on 19 Dec 2012 at 1:06

GoogleCodeExporter commented 9 years ago 
Thankyou!

Original comment by sran...@gmail.com on 19 Dec 2012 at 1:35

GoogleCodeExporter commented 9 years ago 
Fixed in version 1.3.7

Original comment by nico.ma...@gmail.com on 19 Dec 2012 at 1:47

GoogleCodeExporter commented 9 years ago 
OK, it seems now that any "s" after a bracket "(" is now in lower case too.

e.g Some Movie (2005) (stephen Fry)

Original comment by sran...@gmail.com on 19 Dec 2012 at 3:19

GoogleCodeExporter commented 9 years ago 
e.g: 3 Men And a Baby
Result: 3 Men And A Baby (1987) (Tom selleck, steve Guttenberg, Ted Danson).avi

All "s" are lowercase now.

Original comment by sran...@gmail.com on 19 Dec 2012 at 3:28

GoogleCodeExporter commented 9 years ago 
I just look at the code and it seems to be worst than your example.
My condition is very strange, i made a mistake.

Original comment by nico.ma...@gmail.com on 19 Dec 2012 at 3:32

GoogleCodeExporter commented 9 years ago 
I'm tired , i worked all the day on development version, and it is almost 5 AM, 
sorry :-)

Version 1.3.8 will resolve the problem (already online).

Original comment by nico.ma...@gmail.com on 19 Dec 2012 at 3:55

GoogleCodeExporter commented 9 years ago 
Wow! You didn't have to try to fix it straight away!
Thankyou though!

Original comment by sran...@gmail.com on 19 Dec 2012 at 4:49