search

arambalakjian / DataObject-as-Page

A SilverStripe module for displaying DataObjects as Pages
53 stars 27 forks source link

Deleting objects from ModelAdmin list-view (red X) causes problems #12

Closed lingo closed 12 years ago

lingo commented 12 years ago

I don't think this is only occuring in my code, but it's something I've reproduced in 2 environments so far.

To reproduce:

Create a DOAP object. Save and Publish Now delete it using the X in the modeladmin list view.

You should now find that the object is no longer accessible from the CMS, yet remains published on the front-end.

This appears to be because the default TableListField is used as the CollectionController UI and this red "X" button calls delete on the relevant DataObject directly (if I follow the logic right). This means no version cleanup happens, and no un-publish. The big problem is not so much that the item is left published, but that there's then no way to access it.

I'll see if I can subclass TableListField to call a doDelete instead, or failing that will see if there's a way to make it show deleted, but published items. I will post any relevant working commits via github from my fork of DOAP, providing others can confirm this bug.

arambalakjian commented 12 years ago

Hi lingo,

This was fixed a while back, there is now a subclass of tablelistfield in the module. Can you try the latest version and see if this fixes it?

Cheers,

Aram

lingo commented 12 years ago

Ah, brilliant. I thought I'd updated recently, but I guess I must have been confused. Will do so and report back if there are issues. Thanks,

lingo commented 12 years ago

Okay, fantastic. I looked for this in the issues before reporting, but didn't see it. Now all working. Thanks again.