search

arambalakjian / DataObject-as-Page

A SilverStripe module for displaying DataObjects as Pages
53 stars 27 forks source link

Remove string 'delete' argument from doUnpublish FormAction creation #67

Open tmrsiteops opened 8 years ago

tmrsiteops commented 8 years ago

Looks like this is already in master, but in VersiionedGridFieldDetailForm:104, 'delete' should be removed from the FormAction::create method in version 3.1 branch as well:

FormAction::create('doUnpublish', _t('SiteTree.BUTTONUNPUBLISH', 'Unpublish'), 'delete')

dhensby commented 8 years ago

master is the current compatible version with 3.1.x

If you want to open a PR to fix this in 3.1, I'll merge it - but this repo is close to the end of it's life as there are better ways to deal with these problems in SS 3.1+ (ie: using pages and lumberjack)