search

aramds / php-reader

code.google.com/p/php-reader
0 stars 0 forks source link

Calling Zend_Media_Iso14496::write() with argument 'null' gives two warnings, and two notices. #57

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Calling Zend_Media_Iso14496::write() with argument 'null' gives two warnings, 
and two notices. With 'null' as a valid value according to doc, I'm not 
expecting to see any warnings.

Original issue reported on code.google.com by jon.skar...@gmail.com on 8 May 2011 at 1:21

GoogleCodeExporter commented 9 years ago 
*Typo: One warning, one notice - two messages in total

Original comment by jon.skar...@gmail.com on 8 May 2011 at 1:24

GoogleCodeExporter commented 9 years ago 
Can you please provide me with sample code and sample file (either here or to 
my email).

Original comment by svollbehr on 14 May 2011 at 4:22

GoogleCodeExporter commented 9 years ago 
$o = new Zend_Media_Iso14496($file);
$o->write(); // write moov box to the start of the file

It's more of a cosmetic issue really. Changing the write function to allow for 
'null', should remove the warning, E.G

function write($arg=null) {}

Original comment by jon.skar...@gmail.com on 14 May 2011 at 4:27

GoogleCodeExporter commented 9 years ago 
I couldn't replicate the warnings/notices using my PHP 5.3.2 on Windows. I need 
to know more about what is causing the warnings/notices so could you please 
copy the exact output (or preferably a trace using Xdebug) here?

The write does not allow null by default as it inherits method signature from 
Zend_Media_Iso14496_Box class which provides the write method for all boxes in 
order to facilitate write into a stream. The parameter is required there so 
hence it is not possible to overwrite that in Zend_Media_Iso14496 class. A 
minor inconvenience in trade for inheriting other Box features, I'm afraid.

Original comment by svollbehr on 22 May 2011 at 2:35

GoogleCodeExporter commented 9 years ago 
I just realized that the warning is because you call write without having null 
in it explicitly. Calling write() will yield warning because the function 
cannot have a default value due to a restriction described above. Call should 
be made having null as a parameter, ie write(null). I will fix the wiki page 
and close the issue.

Original comment by svollbehr on 25 May 2011 at 2:56