search

aramis-lab / clinica

Software platform for clinical neuroimaging studies
http://www.clinica.run/
Other
220 stars 74 forks source link

[MAINT] Move `merge_nifti_images_in_time_dimension_task` in dwi tasks module #1147

Closed NicolasGensollen closed 5 months ago

NicolasGensollen commented 5 months ago

This PR proposes to move the adapter function merge_nifti_images_in_time_dimension_task from clinica.utils.image to clinica.pipelines.dwi.preprocessing.t1.tasks where other tasks for this pipeline are defined. The function definition is kept in the image module.

AliceJoubert commented 5 months ago

Thanks Nicolas ! I juste have a question ; should those functions be unit tested ? ì don't think I saw any corresponding unit test

NicolasGensollen commented 5 months ago

Thanks Nicolas ! I juste have a question ; should those functions be unit tested ? ì don't think I saw any corresponding unit test

Thanks for the review @AliceJoubert !

The function merge_nifti_images_in_time_dimension is unit tested here:

https://github.com/aramis-lab/clinica/blob/3fdfea6895d0626f9e66b942863aad048c7ab754/test/unittests/utils/test_image.py#L46-L83

The adapter merge_nifti_images_in_time_dimension_task isn't tested by the unit test suite since it is a simple wrapper. It is indirectly tested by the non regression tests though.