Refactor and test `adni_fmap.py`

aramis-lab / clinica

Software platform for clinical neuroimaging studies

http://www.clinica.run/

Other

220 stars 74 forks source link

Refactor and test `adni_fmap.py` #1174

Closed NicolasGensollen closed 2 days ago

NicolasGensollen commented 4 months ago

Following PR #1119 there is some cleaning and refactoring to be done around adni_fmap.py.

More precisely, we need to do:

[x] Add non regression test (requires adding fmap data to CI dataset and making sure that the results are consistent)
[x] Add unit tests
[x] Refactor portions of the code that are difficult to understand

github-actions[bot] commented 4 weeks ago

This issue is considered stale because it has not received further activity for the last 14 days. You may remove the inactive label or add a comment, otherwise it will be closed after the next 14 days.

NicolasGensollen commented 2 days ago

Closing this as refactoring has been done, non regression tests have been added, and adding unit tests will be pursued as a continuous effort.