search

aramk / crayon-syntax-highlighter

Syntax Highlighter supporting multiple languages, themes, fonts, highlighting from a URL, local file or post text.
https://wordpress.org/plugins/crayon-syntax-highlighter/
GNU General Public License v3.0
1.1k stars 249 forks source link

Crayon button in visual editor not working on wordpress 3.9 #167

Closed shaunfreeman closed 10 years ago

shaunfreeman commented 10 years ago

When in the visual editor, when clicking on the add code button no dialog appears, works OK when in HTML mode though. Can this be fixed as I like to work visually and switching between the two is a pain.

Thanks

bxhorn commented 10 years ago

Jumping in to watch this thread…I have the same issue. http://bxhorn.com

smithworx commented 10 years ago

Yep, broken here, too. The error reported in the javascript console is the following:

Uncaught TypeError: undefined is not a function crayon_tinymce.js?ver=359-20131026:54

aramk commented 10 years ago

Are any of you running Wordpress 3.8? If possible, update to 3.9. I'll fix backwards compatibility with 3.8 in any case.

aramk commented 10 years ago

I've fixed this issue in 55500410291d984f0b78f158e54d7b504a9dd5db. Please download the latest zip on the master branch and try it.

Weishaupt commented 10 years ago

This does not fix the issue for me. 78bbc1f has a button with no icon displayed on it the visual editor. Also it is not clickable. 59f8353 has a button with an icon showing. Still not clickable. f37b5488dd8b9fd9ba9226b4c2e98d56f8012e8a Same as 59f8353 behaviour wise.

Not clickable means: If I click on it, nothing happens. I tried this, with all other plugins deactivated.

Weishaupt commented 10 years ago

Okay, I just did some more digging. Chromium is NOT affected by this bug. But Firefox (checked with a fresh profile and on two machines) is. IE seems to be affected, too.

I'm using the latest Firefox 28.0 and Chromium 34.0.1847.116 Ubuntu 14.04 aura

aramk commented 10 years ago

Thanks for that @Weishaupt, I'll patch if for Firefox.

aramk commented 10 years ago

@Weishaupt this is a known issue with Firefox https://github.com/dbushell/Pikaday/issues/91 :frowning:

aramk commented 10 years ago

I've fixed Firefox issues in 8aab8f919f542d65281d2a3d8309ea57bb044bce.

Weishaupt commented 10 years ago

Nice. I can confirm, that the latest master is working for me again. Thanks.