search

arangamani / jenkins_api_client

Ruby Client libraries for communicating with Jenkins Remote Access API
http://github.arangamani.net/jenkins_api_client/
MIT License
416 stars 239 forks source link

Missing crumbRequestField leads to undefined method `downcase' #274

Open grosser opened 6 years ago

grosser commented 6 years ago

idk how this happened but I just saw a weird error were crumbRequestField was not set, so request[@crumb["crumbRequestField"]] = @crumb["crumb"] does request[nil] = foo and that blows up in /net/http/generic_request.rb:71 in []=

is it supposed to be @crumb.fetch("crumbRequestField") -> fail if it is not set or request[@crumb["crumbRequestField"]] = @crumb["crumb"] if @crumb["crumbRequestField"] -> ignore if it is not set ?