Deprecate the active-failover (resilient-single) mode and don't allow starting for v3.12+ - Githubissues

arangodb-helper / arangodb

ArangoDB Starter - starts ArangoDB clusters & single servers with ease.

Apache License 2.0

74 stars 16 forks source link

Deprecate the active-failover (resilient-single) mode and don't allow starting for v3.12+ #395

Closed nikita-vanyasin closed 8 months ago

nikita-vanyasin commented 8 months ago

There are two commits, you can browse them separately to simplify review: 1) Add deprecation warnings

Mark activefailover mode as deprecated
Do not allow starting ArangoDB v3.12+ in active-failover mode
Do not allow upgrade of active-failover mode if the new version is 3.12 or newer

2) Detect arangod version before running tests

refactoring for Docker config options
extracting version detection code to make re-usable
extracting arangod path finder
updating all test checks to ensure proper matching testMode -> detected DB version
also detect if version is ENTERPRISE instead of passing env variable