search

arangodb / arangodb-java-driver

The official ArangoDB Java driver.
Apache License 2.0
200 stars 93 forks source link

Please package with maven-bundle-plugin #474

Open MushyMiddle opened 1 year ago

MushyMiddle commented 1 year ago

Most of ArangoDB's dependencies are packaged with an OSGi manifest (e.g. Jackson). I've successfully rebuilt both this driver, and similar for velocypack, with these changes to pom.xml:

<plugins>... <plugin> <groupId>org.apache.felix</groupId> <artifactId>maven-bundle-plugin</artifactId> <extensions>true</extensions> <configuration> <instructions> <Export-Package>com.arangodb,com.arangodb.async,com.arangodb.async.internal,com.arangodb.async.internal.utils,com.arangodb.async.internal.velocystream,com.arangodb.entity,com.arangodb.entity.arangosearch,com.arangodb.entity.arangosearch.analyzer,com.arangodb.internal.cursor,com.arangodb.internal.http,com.arangodb.internal.mapping,com.arangodb.internal.net,com.arangodb.internal.util,com.arangodb.internal.velocypack,com.arangodb.internal.velocystream,com.arangodb.internal.velocystream.internal,com.arangodb.mapping,com.arangodb.model,com.arangodb.model.arangosearch,com.arangodb.util,com.arangodb.velocystream</Export-Package> </instructions> </configuration> </plugin> ...</plugins

Can ArangoDB's Java artifacts be similarly packaged so we don't have to build/maintain them?

(Feel free to edit the Export-Package list if they don't all need to be exported - this was not a scientific list).

Thanks...

MushyMiddle commented 1 year ago

It seems like at least with the 6.20.0 release of the driver, this has been resolved. The only remaining artifact missing a bundle manifest is jackson-dataformat-velocypack. Thanks.