jsteemann
commented
12 years ago i am abroad at the moment. will merge when i am back in de
Am Freitag, 5. Oktober 2012 schrieb Frank Mayer notifications@github.com:
This adds a version property to Connection.php and a getVersion() to go with it.
I chose Connection.php as it is the most central location. I preferred not to introduce another file just for the version info. However we also can do it this way.
We should have a version that one can use in order to be able to be able handle changes or new features between versions of the API.
For example issue #8 triAGENS/ArangoDB-PHP#8 changes the behavior and and some higher level function could break because of this.
With the version info one can query and react accordingly.
I set Version to 0.3.1 as the last I saw was 0.3.0 but I'll leave it to you to decide.
You can merge this Pull Request by running:
git pull https://github.com/frankmayer/ArangoDB-PHP master
Or view, comment on, or merge it at:
https://github.com/triAGENS/ArangoDB-PHP/pull/10
Commit Summary
Added version variable and a static getVersion() method to COnnection…
File Changes
M lib/triagens/ArangoDb/Connection.php (14)
Patch Links
https://github.com/triAGENS/ArangoDB-PHP/pull/10.patch https://github.com/triAGENS/ArangoDB-PHP/pull/10.diff
— Reply to this email directly or view it on GitHub.
This adds a version property to Connection.php and a getVersion() to go with it.
I chose Connection.php as it is the most central location. I preferred not to introduce another file just for the version info. However we also can do it this way.
We should have a version that one can use in order to be able to be able handle changes or new features between versions of the API.
For example issue #8 https://github.com/triAGENS/ArangoDB-PHP/issues/8 changes the behavior and and some higher level function could break because of this.
With the version info one can query and react accordingly.
I set Version to 0.3.1 as the last I saw was 0.3.0 but I'll leave it to you to decide.