search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
182 stars 45 forks source link

Proposal: Change @package value in phpdocs to triagens\ArangoDB #123

Closed frankmayer closed 11 years ago

frankmayer commented 11 years ago

The "package" phpdoc attribute was ArangoDbPhpClient until now (https://github.com/triAGENS/ArangoDB-PHP/blob/devel/lib/triagens/ArangoDb/AdminHandler.php).

I propose to change it to triagens\ArangoDb in order be more conform and future proof among the multiple implementations that have and will arise.

What do you guys think?

F21 commented 11 years ago

:+1: a +1 to this from me :smile:

frankmayer commented 11 years ago

@jsteemann Is this OK by you? I'd like to wrap up things for the 1.3 release of the driver :smile:

frankmayer commented 11 years ago

I have made that change in a local branch and regenerated the docs. it looks better and more consistent. Waiting for word from @jsteemann to OK this.

jsteemann commented 11 years ago

Sry I overlooked this one. The change is fine for me.

frankmayer commented 11 years ago

Great! Releasing v1.3.0 soon