search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 43 forks source link

hhvm failures #163

Closed F21 closed 10 years ago

F21 commented 10 years ago

Since travis supports hhvm, I have tested Paradox on hhvm. Unfortunately, it seems the socket connection in ArangoDB-PHP fails on hhvm.

This is most likely a problem with hhvm, but we should investigate and find the root cause before opening an issue with them.

See log of failing build here:

https://travis-ci.org/F21/Paradox/jobs/15802655

frankmayer commented 10 years ago

It seems to have to do with fsockopen() ... on line

Since it works under "normal" PHP 5.3, 5.4, 5.5 I'd assume it has something todo with hhvm. However, I don't have a suitable test environment right now, to install hhvm and debug this. Any chance you can have a look at this?

F21 commented 10 years ago

I have installed hhvm into my VM (very simple using prebuilt binaries: https://github.com/facebook/hhvm/wiki/Prebuilt-Packages-on-Ubuntu-13.10).

I will investigate further and open an issue with them. :smile:

F21 commented 10 years ago

I found the cause of the problem.

The endpoint should be tcp://localhost:8529 and not tcp://localhost:8529/. I don't think the endpoint should have the trailing slash anyway, so I have removed it.

A PR has been submitted, so hopefully the tests will pass.