search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
182 stars 46 forks source link

Minor changes for hhvm support. #164

Closed F21 closed 10 years ago

F21 commented 10 years ago

A few changes so we can support hhvm.

F21 commented 10 years ago

Getting this notice:

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

.........................HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

................HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

... 63 / 159 ( 39%)

.HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32

HipHop Notice: Undefined index: 6 in /home/travis/build/triAGENS/ArangoDB-PHP/lib/triagens/ArangoDb/UrlHelper.php on line 32
F21 commented 10 years ago

Please don't merge this yet, while I work out why the above is happening :smile:

F21 commented 10 years ago

@frankmayer This can be merged. The notices were due to a bug in hhvm 2.3.0 that was fixed in 2.3.1. Unfortunately, travis is using 2.3.0 and there appears to be no way to update it to 2.3.1.

When travis updates to 2.3.1, the notices should disappear.

frankmayer commented 10 years ago

Thanks for looking into it :+1: Happy Holidays !!!