arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 43 forks source link

SSL port ignored by the SDK #186

Closed razvanphp closed 8 years ago

razvanphp commented 8 years ago

You can see in HttpHelper class, the ConnectionOptions::OPTION_PORT is still used, even tho it's deprecated, and the port should be part of the endpoint. For SSL it seems you cannot specify it twice.

To be able to connect to an SSL endpoint, I had te replace the second argument of fsockopen with -1, and specify the port only in the ConnectionOptions::OPTION_ENDPOINT. I don't know if this breaks some other connection types tho...

jsteemann commented 8 years ago

Fixed in 2.8 and devel branches. For the 2.8 branch I have created a tag v2.8.1 that contains the modification.