search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 43 forks source link

Simplify composer installation instructions #200

Closed guiwoda closed 7 years ago

guiwoda commented 7 years ago

You shouldn't document how to use composer in this library. Assume composer knowledge, and maybe add a link to its docs if you feel instructions aren't clear enough.

Check any other php library out there for conventions on composer docs.

Previous docs were too verbose and people with knowledge of composer would have to dig deep to find the package name (or end up looking for it in your composer.json instead of the README file.)

jsteemann commented 7 years ago

Thanks for providing this patch!

I am happy to accept the patch, but for legal reasons we need you to fill out and sign our Contributor License Agreement (CLA). You can scan and email the CLA PDF file to cla@arangodb.com or send it via fax to +49-221-2722999-88. Sorry for the inconvenience, but once the agreement is there the PR can be merged.

frankmayer commented 7 years ago

Hi @guiwoda. Thanks for this PR. Can we expect a signed CLA from you in order to be able to merge this PR or should I go ahead and make the necessary changes in a separate commit?

guiwoda commented 7 years ago

You can commit separately, I completely forgot about this and I'm not using the library now, so I don't think I'll be sending PRs this way anyway.

El vie., 10 de feb. de 2017 08:45, Frank Mayer notifications@github.com escribió:

Hi @guiwoda https://github.com/guiwoda. Thanks for this PR. Can we expect a signed CLA from you in order to be able to merge this PR or should I go ahead and make the necessary changes in a separate commit?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/arangodb/arangodb-php/pull/200#issuecomment-278924083, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjNybvGHIIj7pIo11qjHyhJM4XPDsEZks5rbE3JgaJpZM4KlQuo .

frankmayer commented 7 years ago

This was implemented and further changed in a separate commit. Thank you for your effort, @guiwoda