search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 43 forks source link

3.1 FoxxHandler.php (fulfilling #191) #202

Closed tomterl closed 7 years ago

tomterl commented 7 years ago

This pull-request is the 3.1 foxx-api implementation to upload/install and uninstall foxx-applications via php-code as promised in #191.

If the code or tests need adjustments, please comment.

tomterl commented 7 years ago

Hmm - the test failes because static::expectedException() is undefined for php-5.5

tomterl commented 7 years ago

I have a copy of the CLA and see to it, that I send it to you ASAP, after clarifying the details with my employer.

frankmayer commented 7 years ago

Hi @tomterl, thanks for your contribution. Code looks good and tests pass, so, as soon as the CLA is received on ArangoDB's side, we're good to merge.

jsteemann commented 7 years ago

Thanks. Looking forward to merging this.

tomterl commented 7 years ago

There was a 'red-tape incident' -- the cla got lost in the process of getting it approved and signed ;-) -- I just forwarded the pdf and hope that it won't take too long now;

tomterl commented 7 years ago

I just heard the CLA should have reached you already -- Franke & Bornberg ist the corporate entity in question. Let me know, if you need anything else from me.

jsteemann commented 7 years ago

Yes, we got such CLA. I wasn't aware the company was related to this PR. Will merge then.

jsteemann commented 7 years ago

Thanks a lot for the patch. I merged the PR into 3.1, and manually applied the patch in the devel branch.

frankmayer commented 7 years ago

@jsteemann there was a broken test-process with HHVM in Travis, which I missed in my previous commit. It was thus showing build error. I restarted it and this is now fixed, too.

jsteemann commented 7 years ago

@frankmayer: thanks! @tomterl: thanks again for the patch!