search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
182 stars 46 forks source link

json_encode_wrapper: Let $options default to 0 #209

Closed tomterl closed 7 years ago

tomterl commented 7 years ago

hhvm croaks on json_encode($str, null);, make it happy by passing 0 as default options.

The error I got (hhvm-3.18.1): json_encode() expects parameter 2 to be integer, null given

tomterl commented 7 years ago

FWIW here is the relevant part of the backtrace, using arangodb-php-3.1 branch:

2017-03-01 16:38:34 - cranston - [19261] - error: json_encode() expects parameter 2 to be integer, null given
        ./libs/arangodb/lib/triagens/ArangoDb/Connection.php ErrorHandler::handleError(...) (724)
        ./libs/arangodb/lib/triagens/ArangoDb/Connection.php triagens\ArangoDb\Connection->json_encode_wrapper(...) (724)
        ./libs/arangodb/lib/triagens/ArangoDb/Handler.php triagens\ArangoDb\Handler->json_encode_wrapper(...) (77)
        ./libs/arangodb/lib/triagens/ArangoDb/DocumentHandler.php triagens\ArangoDb\DocumentHandler->save(...) (339)
        ./libs/arangodb/lib/triagens/ArangoDb/DocumentHandler.php triagens\ArangoDb\DocumentHandler->store(...) (282)
frankmayer commented 7 years ago

Thanks for your contribution @tomterl ! :+1: