search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 44 forks source link

make byExample() and firstExample() batch'able #212

Closed hwde closed 7 years ago

hwde commented 7 years ago

It seems to me that byExample could be used in batch very well, but I'm unsure how to handle "nothing found" of firstExample()

frankmayer commented 7 years ago

Was the uncertainty, described in the first comment, resolved? If so, tests would also be great. ;)

hwde commented 7 years ago

Well, I thought about to throw a ServerException for not found in batched firstExample() ... but there are other function calls (i.e. CollectionHandler::has()) which also just return false for not found instead of throwing an excption. I'll will push a pull request with a test for the current behaviour in a few minutes.