search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 44 forks source link

Add optional body param to delete request #234

Closed sandrokeil closed 6 years ago

sandrokeil commented 6 years ago

Close #233

jsteemann commented 6 years ago

I am happy to accept the patch, but for legal reasons you will need to fill out and sign our Contributor License Agreement. You can scan and email the pdf file to cla@arangodb.com or send it via fax to +49-221-2722999-88. Sorry for the inconvenience, but once the agreement is there this PR and any following can be merged easily.

sandrokeil commented 6 years ago

@jsteemann I've signed the CLA. It looks like the Travis config is out of date.

pwd: /home/travis/build/arangodb/arangodb-php/tests/travis
./tests/travis/setup_arangodb.sh: line 68: /home/travis/build/arangodb/arangodb-php/tests/travis/ArangoDB-devel/bin/arangod_x86_64: No such file or directory
Check for arangod process
no 'arangod' process found
ARCH = x86_64
The command "./tests/travis/setup_arangodb.sh" failed and exited with 1 during .
Your build has been stopped.
jsteemann commented 6 years ago

Yes, the TravisCI config is definitely out of date. I'll check that tomorrow. I probably have to adjust the configuration much more than I thought in order to make it more up-to-date.

jsteemann commented 6 years ago

Update on this: the TravisCI configuration still needs some proper fixing. It looks like the exact type of builds that the driver has used are not automatically published on arangodb.com/repositories. We'll probably change this to use some Docker-based setup, but it needs a few more days for the setup.

jsteemann commented 6 years ago

Merging this PR anyway now.

sandrokeil commented 6 years ago

@jsteemann For my tests, I use the bash script from the travisCI repository, see my .travis.yml. But not all ArangoDB versions are available.

These lines are mandatory too.

after_script:
  - killall -s SIGTERM arangod_x86_64
jsteemann commented 6 years ago

Exactly this is the problem: the versions in the TravisCI repository seem to be outdated, and do not seem to be built automatically daily/nightly. I think for the PHP driver and other drivers we will definitely move the TravisCI tests to use a Docker container with latest ArangoDB builds. I need someone here to set it up so these containers are built regularly, so it may take a day or two to set up.

sandrokeil commented 6 years ago

Alright, maybe this example may help you.

jsteemann commented 6 years ago

Thanks. I now got a docker build and set up the tests to use it.