search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
183 stars 44 forks source link

implementing JsonSerializable interface. #245

Closed a-shafaat closed 5 years ago

a-shafaat commented 5 years ago

Signed-off-by: amirrezashafaat_desktop amirrezashafaat@gmail.com

Please note that for legal reasons we require you to sign the Contributor Agreement before we can accept your pull requests.

jsteemann commented 5 years ago

I am happy to accept the patch, but for legal reasons you will need to fill out and sign our Contributor License Agreement. You can scan and email the pdf file to cla@arangodb.com or send it via fax to +49-221-2722999-88. Sorry for the inconvenience, but once the agreement is there this PR and any following can be merged easily.

a-shafaat commented 5 years ago

I have send the CLA (exactly when i created the pull request)

On Wed, Jul 25, 2018, 1:06 AM Jan notifications@github.com wrote:

I am happy to accept the patch, but for legal reasons you will need to fill out and sign our Contributor License Agreement https://www.arangodb.com/documents/cla.pdf. You can scan and email the pdf file to cla@arangodb.com or send it via fax to +49-221-2722999-88. Sorry for the inconvenience, but once the agreement is there this PR and any following can be merged easily.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arangodb/arangodb-php/pull/245#issuecomment-407543518, or mute the thread https://github.com/notifications/unsubscribe-auth/AdHLV11AEk6plQYfqol8ozYihVaZtxUXks5uJ4VggaJpZM4VdVYF .

jsteemann commented 5 years ago

@Ashafaat : alright, thanks! CLAs are processed manually, so I guess someone will put you on the list of contributors tomorrow :smile:, and I will then merge.

a-shafaat commented 5 years ago

hi, CLA approved. (i recieved an email about that)

thanks.

jsteemann commented 5 years ago

Thanks for the PR! I will address the failing test later today. It seems unrelated to your PR.

jsteemann commented 5 years ago

Test fixed.