search

arangodb / arangodb-php

PHP ODM for ArangoDB
https://www.arangodb.com
Apache License 2.0
182 stars 46 forks source link

Issue #290 - Support PHP 8.1 #291

Closed Sweetchuck closed 1 year ago

Sweetchuck commented 2 years ago

Issue #290 - Support PHP 8.1

cla-bot[bot] commented 2 years ago

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

cla-bot[bot] commented 2 years ago

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

Geolim4 commented 2 years ago

Hello @Sweetchuck can you fix the PR please ? :D

Sweetchuck commented 2 years ago

@Geolim4

  1. Download a PDF
  2. print it on papper
  3. fill the form and sign it
  4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

Geolim4 commented 2 years ago

@Geolim4

1. Download a PDF

2. print it on papper

3. fill the form and sign it

4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

Wait what ? They require to sign and re-send a PDF ? oO Didn't noticed that, my bad. This new "CLA" trend is completely counterproductive.

Sweetchuck commented 2 years ago

I just rebased this branch to the latest „devel” branch.

Sweetchuck commented 2 years ago

The fail is totally irrelevant.

\ArangoDBClient\AdminTest::testGetServerMetrics line 262. expected: arangodb_server_statistics_server_uptime_total most closer actual: arangodb_server_statistics_server_uptime

But after that: static::assertEquals("counter", $metric["type"]); actual: gauge

static::assertTrue(is_numeric($metric["sum"])); \ Undefined index: sum \ /.../triagens/arangodb-php-3.x/tests/AdminTest.php:276

Docker image arangodb/arangodb-preview:3.9.0-nightly as defined in tests/travis/setup_arangodb.sh

Why nightly?

Sweetchuck commented 2 years ago

Related Issue: #294