search

arangodb / arangojs

The official ArangoDB JavaScript driver.
https://arangodb.github.io/arangojs
Apache License 2.0
601 stars 107 forks source link

produce esm build for bundlers #731

Closed meadowsys closed 3 years ago

meadowsys commented 3 years ago

would it be possible to create an es module build for use in bundlers like rollup?

pluma commented 3 years ago

We did this in an older major version and it got messy to maintain. There are currently no plans to do this as the main benefit tends to be tree shaking, which doesn't seem to have any effect because of how this library's API works.

meadowsys commented 3 years ago

ah I see. I'm targeting node and don't really care too much about tree shaking honestly.

My main concern is about having to use @rollup/plugin-commonjs, which takes a commonjs module and converts it to esm so it can be used in rollup. I don't feel that great about this because the code was transpiled from typescript down to commonjs, and then back up to esm.

As an alternative, I could try installing the Github repo and then importing the ts source files, and have rollup typescript plugin handle transpilation from typescript

meadowsys commented 3 years ago

hmm.. I am not actively needing or pursuing this at the moment, and if it is too difficult to maintain I understand that it is not worth the maintenance cost. I will close this, but thank you for considering!