DOC-660 | Improve logic for "Show more"

arangodb / docs-hugo

Source code of the ArangoDB online documentation

https://docs.arangodb.com

Apache License 2.0

5 stars 5 forks source link

DOC-660 | Improve logic for "Show more" #517

Closed Simran-B closed 5 months ago

Simran-B commented 5 months ago

Description

Don't use conflicting detection of long code blocks (element height vs. number of lines).
Ensure we always reveal ~5 lines or don't collapse content.
Don't collapse code blocks already hidden by default ("Show output").

Collation Analyzer example no longer cut off (below threshold), last AQL Analyzer example with "Show more" button:

https://deploy-preview-517--docs-hugo.netlify.app/stable/index-and-search/analyzers/#collation

Upstream PRs

3.10:
3.11:
3.12:
3.13:

arangodb-docs-automation[bot] commented 5 months ago

Deploy Preview Available Via
https://deploy-preview-517--docs-hugo.netlify.app

Simran-B commented 5 months ago

From testing the threshold:

Simran-B commented 5 months ago

Discovered an issue: tabbed examples like for ArangoSearch only get the "Show more" button for the active tab. The other tab is hidden, therefore the content has no height, and the code for adding the button is skipped (this is good for "Show output" but not for tabs).