search

arangodb / linenoise-ng

A small self-contained alternative to readline and libedit that supports UTF-8 and Windows and is BSD licensed.
Other
359 stars 53 forks source link

[c894b9e] Fix insecure history file creation #4

Closed theopolis closed 7 years ago

theopolis commented 8 years ago

This change is ported from c894b9e within the upstream linenoise project.

jsteemann commented 8 years ago

Thanks for providing this patch!

I would be happy to accept the patch, but for legal reasons we need you to fill out and sign our Contributor License Agreement (CLA). You can scan and email the CLA PDF file to cla@arangodb.com or send it via fax to +49-221-2722999-88. Sorry for the inconvenience, but once the agreement is there the PR can be merged.

theopolis commented 8 years ago

Ok, no worries, give me a few days.

Also, since you have a few repos in the organization, have you considered something like CLAbot: http://clabot.github.io/#documentation

jsteemann commented 8 years ago

I think we used some automated thing like CLAbot in the past, but we couldn't use it anymore due to legal reasons (company lawyers required us to collect "real" signatures - don't know any more details as I am just a developer and are happy to ignore all that legal stuff whenever I can).

fceller commented 7 years ago

@theopolis thanks a lot for your fix. Can you sign a contributor licence agreement available at https://www.arangodb.com/documents/cla.pdf?

fceller commented 7 years ago

The disadvantage of this approach is, that it changes the process umask. This can be dangerous in multi-threaded programs.