arangodb / spring-data

Spring Data ArangoDB
https://www.arangodb.com/docs/stable/drivers/spring-data-getting-started.html
Apache License 2.0
110 stars 56 forks source link

open up DefaultConverter to be overridable #272

Closed wuwu2000 closed 1 year ago

cla-bot[bot] commented 1 year ago

Fresh avocado detected! Welcome and thank you for your contribution @wuwu2000. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

rashtao commented 1 year ago

Rejecting this PR, since a custom conveter can be provided by overriding com.arangodb.springframework.config.ArangoConfiguration#arangoConverter():

https://github.com/arangodb/spring-data/blob/479358aac3794cdf3c391f63473a643daeb2e411/src/main/java/com/arangodb/springframework/config/ArangoConfiguration.java#L71-L75

Please reopen if still relevant.