search

aranja / rakning-c19-app

App that helps to analyse individuals’ travel and trace their movements when cases of infection arise.
https://covid.is/app
MIT License
239 stars 31 forks source link

Added Change Language Screen #73

Closed pjanaya closed 4 years ago

pjanaya commented 4 years ago

After feedback received in #67, and for improving the support of #58, this PR includes a new option to change the language once the user has logged in. It's a new button on the bottom of the Home Screen.

It reuses most of the Language Picker implementation, but the title and subtitle for that screen don't make sense in this case. If you access that screen from the Home Screen you won't see any title right now, although I guess ideally it should include a title. Again, trying to strike a balance here between polluting and perfection. Adding a different title would mean that we have to make the Language Picker screen configurable. It would be as simple as adding to the screen a new title like "Change language" that would only be shown if you reach that screen from the Home. However, for the reaaaally small percentage of users who will use this option, I think is good enough.

Anyway, your app, your choice, let me know if you want something different :)

Screen-Recording-2020-04-19-at-23 55 51

eirikurn commented 4 years ago

Oh, this is a much better design. Thanks for taking this all the way. 🤩

I'll finish the code review later.

arnorb commented 4 years ago

Not a big deal but I would like to point out that flags are not languages.

eirikurn commented 4 years ago

@arnorb good point. Probably worth creating an issue/PR about. Should be fine to remove all flags from language-related UI.