ararchch / pe

0 stars 0 forks source link

Typing weight 2 removes the weight #11

Open ararchch opened 4 months ago

ararchch commented 4 months ago

User may type this accidentally, would be nice to warn them rather than removing datapoint.

image.png

image.png

nus-se-bot commented 4 months ago

Team's Response

This is documented behaviour of the weight command in the user guide.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As highlighted in my earlier report, I do not argue that this command was misrepresented in the UG. However I do belive that this is a feature flaw because it is not as well developed as it should be.

As indicated by the 2103T website:

image.png

As the command to edit or enter someone's weight involved typing weight[index] and then their weight value, I can definitely foresee someone accidentally pressing enter after typing the first two parts, which would result in the deletion of the person's last recorded weight altogether. In fact I myself did this the first time I tried to edit weight.

This is compounded by the fact that once deleted it can never be recovered because it was a historical datapoint of someone's weight, as such it can significantly impact the tracking of a person's progress.

While I understand that this is listed in the UG, i think that adding a simple warning message via a pop up, or requesting for confirmation can go a long way in preventing this issue which I definitely think is relevant. I would understand if the team highlighted that this feature was not in scope for v1.4 because there might be other more important ones, but at some point down the line I do think that this is something that one should implement to improve user experience, so I disagree with the rejection of the bug.

Notation of weight command:

image.png