ararchch / pe

0 stars 0 forks source link

Unnecessary images included in JAR file, causing bloat #2

Open ararchch opened 4 months ago

ararchch commented 4 months ago

Overview There exist unnecessary images in the JAR file that cause it to be larger than required. Would be nice to remove them to reduce usage of the users system

Steps to reproduce

Expected behaviour

Actual behaviour

Potential solution

Screenshots Unnecessary files image.png

Fitbook logo is still that of AB3

image.png

soc-pe-bot commented 4 months ago

Team's Response

There are 2 issues reported in this bug report, we are choosing to respond to the 2nd one. (Old window logo)

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Logo of Fitbook when run on computer (windows) does not match the UG

Overview Quite self explanatory, notice the difference in the Logos in the image below. would be nice to change this to make sure the user isnt confused

Steps to reproduce

  • Run fitbook on a windows computer
  • view logo in task bar or at the top of the fitbook window

Expected behaviour

  • Logo is the fitbook logo as indicated in the pictures in UG

Actual behaviour

  • Logo is still AB3 logo

Potential solution

  • Change the logo to match the UG

Screenshots Actual -> image.png

From UG -> image.png


[original: nus-cs2103-AY2324S2/pe-interim#2346] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

This is a purely cosmetic issue that could be classified as a documentation bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is talking about the bloat in the jar file, while the other issue is about the fitbook logo. I think the team is misled by the very last image I inserted in the orignial report, but I think that it is because they are taking it out of context.

It is clearly mentioned in my bug report, the fitbook_logo.png file has not been used -> image.png

And the screenshot I inserted at the end is proof to show that the fitbook logo is still the existing AB3 logo, which means that the fitbook_logo.png file has not been used (i.e. this was evidence of the bloat).

I think that in the context of my main bug report which is quite detailed in highlighting the problem, the message is clear and that this is not a duplicate bug.

image.png


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is not documentation related but related to the jar file.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not a cosmetic bug.