Open ararchch opened 4 months ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
Incorrect note parameter leads to fitbook ignoring the note rather than prompting the user of incorrect command format
Overview When the tag for note is incorrectly typed, fitbook does not seem to recognise that as the issue, but rather goes ahead to execute the command and ignoring the note. This is because the note is considered part of the address ( i think)
Steps to reproduce
- Start up fitbook
- Enter
add n/Johffn Doe p/98765432 e/johnd@gmail.com a/John street, block 123,#01-01 ni/john from school
Expected behaviour
- Error message saying that command format is wrong
Actual behaviour
- Client is added to book
Potential solution Check for note or possible wrong formats before assuming it is the address
Screenshots
[original: nus-cs2103-AY2324S2/pe-interim#3581] [original labels: severity.Medium type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
We understand where the tester is coming from. Indeed it would be useful if users are corrected for minor typos, to the command prefix.
However, we are rejecting this for the following reasons:
- It's not a bug.
According to the UG, any text is allowed, so this input would be considered valid.
- This is intended behaviour.
Unless a new prefix is specified, all text is assumed to belong to the address.
Therefore, we chose to reject this bug.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: This bug concerns the error message displayed while the other one is about the user being added to fitbook. I think that while they are similar, to consider them duplicates is a stretch.
based on the CS2103T website definition of a duplicate bug, the two in question here are neither the same bug, and would require independent fixes, hence I do not believe that they are duplicates.
Overview App does not recognise the true issue, and prompts user incorrectly as seen below in images.
Steps to reproduce
Expected behaviour
ra/
should ber/
Actual behaviour
Potential solution
Screenshots