PHP: Hamcrest_Matchers should import the matchers inside the factory methods

arashja / hamcrest

Automatically exported from code.google.com/p/hamcrest

0 stars 0 forks source link

PHP: Hamcrest_Matchers should import the matchers inside the factory methods #139

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Instead of importing everything at the top, each factory method should 
require_once the matcher it calls. Since this file is generated by the script, 
it's an easy change.

Original issue reported on code.google.com by dharkn...@gmail.com on 17 Feb 2011 at 7:38

GoogleCodeExporter commented 8 years ago

Original comment by dharkn...@gmail.com on 17 Feb 2011 at 7:40

Added labels: PHP

GoogleCodeExporter commented 8 years ago

I moved the imports, however the global functions are still calling 
Hamcrest_Matchers, but now they are also doing the import. It's not horrible, 
but it's wasteful. Instead, the global functions should call the matcher 
factory methods directly and bypass Hamcrest_Matchers.

Original comment by dharkn...@gmail.com on 12 Mar 2011 at 12:28

Changed state: Fixed