Open francepack opened 4 years ago
@evilaspaas1
Thank you for revisiting this- I see you have made changes to all the areas I mentioned, and everything looks good! You are officially technical ready
!
Since I can't let anyone escape with at least a little more feedback, something I noticed was that type_of_pizza attribute doesn't intuitively read as an array to me. Something plural may communicate that slightly better- perhaps toppings.
Great job! Keep up the hard work!!
@evilaspaas1
You performed well enough on the assessment to merit a chance to make some changes that can promote you to
technical ready
. Please make the following updates by EOD Saturday:[ ] Review this key for part 3, the variables.txt file- Update any inconsistencies you see as practice bug catching.
[ ] In your class1.txt and class2.txt files, please revise to use consistent casing conventions- methods and attributes should be all lower case, while class names use pascal case.
[ ] Look at your Burger methods- good ideas overall, but for extra practice, try to rename
size_of_burger
to bring an action to the front of the name.Please feel free to ask me any questions about this.