Crash when browsing the emotes/the game shows suggestions from manually typing emote codes

ChromaPIE commented 4 months ago

Describe the bug

Title. It feels like it's because the game getting overloaded bc I loaded 5 resourcepacks with, I'm sure over 1000 emotes. I've allocated over 9000mb of RAM to Minecraft so definitely it's not an low-end related issue.

Which side have you encountered the bug on?

Client

Steps to reproduce

Described above

Logs

No crash log, only this: https://mclo.gs/DKbZVXt

Additional context

No response

aratakileo commented 4 months ago

It's incredible, you still managed to reach the limit on the number of emojis. I didn't expect it to happen so soon! Here, hold the badge «🚀»

aratakileo commented 4 months ago

As for the problem itself:

the probability of it being played by other players is quite low. It is unlikely that a player will add at least 1000 emojis to the game
the emoji limit depends on the amount of memory allocated to the game, as well as on the availability of other resource packs

so I don't think I'll be dealing with this issue anytime soon

ChromaPIE commented 4 months ago

may i keep the badge if i told you I've decreased the number to 400+ and still got the crash? They are all in one single resourcepack and it's generated from a popular emote server, which I think many players will use it or a similar server as a one stop shop to set up emogg, and it's reasonable.

Did another few tests and it seems like it's not the number of the emote that truly matters, it's the file size of the emote.

The game was all fine till it starts to play big gif files, from my test it's confirmed that when the game tries to play two gifs, with both file sizes around 200 KB, it freezes/crashes. Discord allows gif files up to 256 KB, them causing fatal problem in the mod doesn't make much sense to me.

And if it's technically impossible to solve the issue on the game side, the generator should check before generation if the size of the emotes are all below a certain dangerous limit, highlight them in red, and provide options to continue anyway, continue without dangerous emotes, or abort the task.

The mod is awesome and definitely worths some QoL support.

aratakileo commented 4 months ago

Of course you can. Let me even give you a second badge.

Well, based on the new circumstances that you have found out, this problem looks more serious. I'll think about what I can do, but I don't think I can make any major improvements.

I would also like to know more about QoL, what exactly do you mean by this

aratakileo / emogg