search

araucaria-project / pyaraucaria

OCA Observatory and Araucaria Project Common Routines Library
0 stars 2 forks source link

deg_str_to_deg is a repetition #13

Closed majkelx closed 1 year ago

majkelx commented 1 year ago

The method deg_str_to_deg duplicates functionality of the existing method deg_to_decimal_deg from the same file.

I would suggest removing the new one.

MMiirrkk commented 1 year ago

Oh sorry, i didn't noticed. Will do with next occasion.

MMiirrkk commented 1 year ago

@majkelx now I do remember why I created mine. Method have some error, because it can't calculate value in 'XXX:XX:XX' format:


w = deg_to_decimal_deg('304:18:05')
Traceback (most recent call last):
  File "/home/mirk/aprograms/pyaraucaria/pyaraucaria/coordinates.py", line 65, in deg_to_decimal_deg
    val = float(dms)
ValueError: could not convert string to float: '304:18:05'
majkelx commented 1 year ago

@MMiirrkk reopen to remove duplicated method.

MMiirrkk commented 1 year ago

In ocabox is removed. After check in -cli will be removed from pyaraucaria.

MMiirrkk commented 1 year ago

deg_str_to_deg is removed. Issue done.