search

arauchfuss / Simple-Comic

OS X comic viewer
http://dancingtortoise.com/simplecomic/
MIT License
1.09k stars 226 forks source link

Improve Unicode support in Zip archives #83

Open CyberSkull opened 11 years ago

CyberSkull commented 11 years ago

Very new Unicode characters don't get along with Simple Comic.

For example, I have a zipped archive (in UTF-8) with SPLASHING SWEAT SYMBOL Unicode: U+1F4A6 (U+D83D U+DCA6), UTF-8: F0 9F 92 A6 (GitHub doesn't want to let me put the actual symbol in) in the file names. Simple Comic doesn't recognize these and asks me for the encoding. Then in the encoding chooser UTF-8 isn't an option. I can unzip the file with zip or StuffIt and the files are correctly named.

When I open a plain image or directory it seems to work ok, regardless of how the file is named.

What I'd like to see is better unicode detection for Zip and other archives (I can only confirm this bug with Zip archives using UTF-8 encoding).

arauchfuss commented 11 years ago

I am going to update the archive handler and get rid of the current file encoding selection system if I can.

arauchfuss commented 7 years ago

Not sure how hard it will be to remove Universal Detector completely but I want to give it a shot.