arayabrain / barebone-studio

pipeline tool
GNU General Public License v3.0
1 stars 3 forks source link

Refactoring loading icon display at API request #376

Closed itutu-tienday closed 2 months ago

itutu-tienday commented 3 months ago

standalone-loading-icon.webm

multiuser-loading-icon.webm

itutu-tienday commented 3 months ago

@tsuchiyama-araya @milesAraya please review this PR.

milesAraya commented 2 months ago

I was able to see the loading wheel in Native version. Because of the speed of the M3 chip, I needed to add a sleep pause to see the loading wheel. Added these lines to workflow.py): async def fetch_last_experiment(workspace_id: str): last_expt_config = ExptUtils.get_last_experiment(workspace_id) import time time.sleep(2) import logging logging.info("Loading icon should be displayed now")

However, with Docker I was not able to see the loading icon. The logging still occurred correctly

studio-dev-be-1 | 2024-07-08 20:01:28,341 INFO: [root] fetch_last_experiment():35 - Loading icon should be displayed now

Note, I have had issues with Docker on my PC. The.e is also a chance this is related to using an M3 chip/

tsuchiyama-araya commented 2 months ago

こちらをDockerで確認したところ、 Loadingアイコンを確認できませんでした。

行った作業 ・feature/refactor-api-loading-iconのブランチに切り替えました ・docker compose up -d でDockerを立ち上げました ・動作確認

milesAraya commented 2 months ago

The loading icon appeared in native and also in docker in the frontend container.