arazni / blades-in-the-sheets

A Blades in the Dark character sheet progressive web app in WebAssembly
https://arazni.github.io/blades-in-the-sheets/
7 stars 1 forks source link

Fix/accessible #24

Closed arazni closed 1 year ago

arazni commented 1 year ago

I don't have a screen reader yet, but I was able to try to meet all the messages I understood from the WAVE extension.

I'm unsure what to do about MudRating components for the moment. WAVE says it should have a fieldset. I tried applying an id and an aria-label to the MudRating, but it seems not to make WAVE happy. Each "rating" (like experience checkbox within the app) is considered its own radio button by WAVE, which causes it to complain about them not having compliant labels. However, MudRating seems to apply aria-hidden to each of the radio buttons, so even if it were compliant, it seems like it would be hidden from a screen reader.

This is my major remaining confusion with the WAVE extension specifically.

My major concern outside of that is that I need to start testing with a screen reader.

This update also comes with some color changes for contrast compliance and some component re-orders for better tabbing. I have retested all the tabbing behavior on the character sheet and it seems to be in a better place. However, the MudExpansionPanels do not seem to have an intuitive way to be targeted by tabbing, so I'm not sure how to trigger the expansion by keyboard.