search

arb / celebrate

A joi validation middleware for Express.
MIT License
1.33k stars 66 forks source link

Updated @types/joi to be a dependency instead of devdependency #110

Closed Calme1709 closed 5 years ago

Calme1709 commented 5 years ago

This is done as if @types/joi is not installed else where in the project by the user, it will not be installed if the module is used as a dependency, meaning that the types that are required in the type definition file will not be present.

codecov-io commented 5 years ago

Codecov Report

Merging #110 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #110   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          64     64           
  Branches       11     11           
=====================================
  Hits           64     64

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 362a15e...8686be8. Read the comment docs.

arb commented 5 years ago

Thank's for the PR. I'm not going to land this because, in my opinion, the things listed under dependencies are the things required to make the code function. Anything beyond that is just a better development experience or for contributing.

Because this isn't a TS module, I only expose and maintain the type def file to ad to the developer experience and it is therefor not required to make the code execute.