Closed KillWolfVlad closed 5 years ago
Merging #112 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 62 62
Branches 10 10
=====================================
Hits 62 62
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 503b6d6...bc42852. Read the comment docs.
Can you do this again with the following steps?
1. Start clean `rm -rf node_modules`
2. Just install the package lock ... `npm ci`
3. Just Update the package you need `npm update PACKAGE_NAME`
I don't want the entire package.lock file regenerated for a single dev dependency if we can help it.
@arb can you do it on your side? npm
regenerate package-lock.json
when I use install
and remove
commands.
@arb do you interested in fixing this issue?
Yes, I just haven't quite gotten to it yet. Also since it's not preventing anyone from using this library it's not high priority. When I tried it locally, I had almost as many package.lock changes myself so I'm thinking about how I want to handle this.
This is causing issue when you use @hapi/joi
package. As you are including joi
internally and providing it, please make sure the types match. This is giving issue in my typescript project. I think merging this pull request will solve it.
Trumped by #114. Published as 10.0.1.
joi
has been renamed to@hapi/joi
, but types don't support it.